feat(bin): node --full flag
#3965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekhirin
added
A-cli
Codecov Report
... and 11 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
onbjerg
requested changes
Jul 31, 2023
bin/reth/src/args/pruning_args.rs
Outdated
Comment on lines
27
to
29
| // Beacon Deposit Contract deployment block | ||
| // https://etherscan.io/tx/0xe75fb554e433e03763a1560646ee22dcb74e5274b34c5ad644e7c0f619a7e1d0 | ||
| receipts: Some(PruneMode::Before(11052984)), |
There was a problem hiding this comment.
Would add a note here that this is mainnet specific, so this does not work on Sepolia. Thinking about it a bit more - we should either make this handle all our known networks (incl. Sepolia), or (for now) block it so --full only works on mainnet. Wdyt?
There was a problem hiding this comment.
Mainnet: 11052984
Goerli: 4367322
Sepolia: 1273020
Gnosis: 19469077
Holesky: 1 probably, don't prune receipts at all
onbjerg
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3960
Adds a flag that enables a full node pruning configuration. It takes precedence over pruning configured via reth.toml.
The rationale behind chosen values:
transaction_lookup: Noneis required to be able to serveeth_getTransactionByHashand similar RPCs which requiretx_hash -> tx_numbermapping.receipts: Some(PruneMode::Before(11052984))is required for CL to be able to reconstruct the deposits cache. The beacon deposit contract was deployed on this block: https://etherscan.io/tx/0xe75fb554e433e03763a1560646ee22dcb74e5274b34c5ad644e7c0f619a7e1d0.The flag is hidden from
--helpuntil we're ready for production use: